add WebRTC transport#1999

Closed

GlenDC wants to merge 250 commits intolibp2p:masterfrom

GlenDC:feat/webrtc

Commits on Jan 14, 2023

Commits on Jan 17, 2023

address remarks of myself of original PR
glendc
committed
improve state.go
glendc
committed

Commits on Jan 18, 2023

Add notes from ckousik to codebase
glendc
committed
enable transport (webrtc) tests that do work
glendc
committed

Commits on Jan 19, 2023

make DiaerCanCreateStreams test pass again
glendc
committed
further improve state management
glendc
committed
minor code changes
glendc
committed
minor improvements mux.go (webrtc)
glendc
committed
do not pass string by value in mux.go where not needed
glendc
committed
fix bug in webrtc mux: refactor now passes all tests
glendc
committed
fix staticcheck tests
glendc
committed
add link to go-libp2p webrtc spec
glendc
committed
add WebRTC benchmarking tool
glendc
committed

Commits on Jan 21, 2023

disable std transport test on purpose for WebRTC
glendc
committed
start cleaning up webrtc bench tool
glendc
committed
implement metrics tracker (stdout or csv file)
glendc
committed
fix linting issues
glendc
committed

Commits on Jan 23, 2023

improve metrics tracking
glendc
committed
add report metrics cmd
glendc
committed

Commits on Jan 24, 2023

add metrics vis and improve reporting + doc
glendc
committed
remove unused pool extra MTU size
glendc
committed
document how to profile using the webrtc benchmark tool
glendc
committed
remove TODO from README of webrtc benchmark
glendc
committed

Commits on Jan 25, 2023

add Benchmark chapter to WebRTC BM tool README
glendc
committed
use correct scripts for benchmark example cmds
glendc
committed
also keep tracks of bytes read/written in metrics for WebRTC
glendc
committed
bugfix metrics collection client/server (webrtc)
glendc
committed

Commits on Jan 26, 2023

move visualise to sep dir & support autogen csv metrics file name
glendc
committed
make visualise script work with multiple files (e.g. server/client)
glendc
committed
include results (CSV) in benchmark results
glendc
committed
continue to improve benchmark code
glendc
committed
define transports for benchmark explicitly
glendc
committed
add fork reference and update listrenPort
glendc
committed
give back 9999 listen port for benchmark tool as def
glendc
committed
divide CPU % by total cpu cores as to get actual %
glendc
committed
remove dead code (client sdp (2))
glendc
committed

Commits on Jan 28, 2023

Commits on Jan 30, 2023

add benchmark files for webrtc and other transports
glendc
committed
add more graphs to webrtc README benchmark
glendc
committed
fix cases for ws png image link in README
glendc
committed
fix dial cmd multirunner for s2 benchmark
glendc
committed
go mod tidy
glendc
committed
fix tests CI (multirunner flag parse)
glendc
committed

Commits on Jan 31, 2023

Commits on Feb 1, 2023

fix open TODOs that can be fixed
glendc
committed
minor improvement, mostly styling
glendc
committed
remove outdated code and remove unneeded string alloc
glendc
committed
optimise hex conversions further and string allocs
glendc
committed
remove duplicate hex code
glendc
committed
avoid even more string allocs
glendc
committed
go mod tidy
glendc
committed
update benchmarks based on latest PR branch status
glendc
committed
avoid more string allocs
glendc
committed
add TODO to flaky test
glendc
committed

Commits on Feb 2, 2023

fix ch leak and minor ux improvements
glendc
committed
remove TODO regarding flaky test, might have been fixed already
glendc
committed
log dial error when it occurs in prod
glendc
committed

Commits on Feb 3, 2023

Merge remote-tracking branch 'origin/master' into feat/webrtc
glendc
committed
go mod tidy
glendc
committed
minor improvements and more docs
glendc
committed
go mod tidy testplans
glendc
committed
increase dial timeout for MaxInFlightRequests test
glendc
committed

Commits on Feb 4, 2023

resolve data race in muxed_connection.go
glendc
committed
code cleanup
glendc
committed
clean up code
glendc
committed
simplify code regarding maxInFlight
glendc
committed

Commits on Feb 5, 2023

refactor stream.go (webrtc)
glendc
committed
skip broken tests (due to refactor)
glendc
committed
ensure response writer can handle if responseCh is blocked :)
glendc
committed
swap done check
glendc
committed
remove unused varf
glendc
committed

Commits on Feb 6, 2023

split up stream code (webrtc)
glendc
committed
move util webrtc code to internal package (soc)
glendc
committed
move Signal also to its own internal package for WebRTC
glendc
committed
add forgotten pointer for ref function
glendc
committed

Commits on Feb 7, 2023

move state back into webrtc stream
glendc
committed

Commits on Feb 8, 2023

more refactor: deadline fix
glendc
committed

Commits on Feb 9, 2023

simplify/refactor stream code
glendc
committed
remove unused props/types of stream
glendc
committed
Merge remote-tracking branch 'origin/master' into feat/webrtc
glendc
committed
fix max in flight conn test
glendc
committed
sync code with original ckousik code
glendc
committed
re-add closeErr hack defined by ckousik (just to be sure)
glendc
committed
fix tests: all should pass now
glendc
committed
update benchmarks for webrtc for latest code
glendc
committed
update S2 benchmarks (FC)
glendc
committed
simplify WebRTC reader code (fix deadline bug)
glendc
committed
accept webrtc accept queue better
glendc
committed

Commits on Feb 10, 2023

switch establishing conns (webrtc) to worker pool
glendc
committed

Commits on Feb 12, 2023

remove benchmark to sep repo
glendc
committed
doc hex interpersed + remove async/mutex
glendc
committed
resolve more review comments
glendc
committed
give pckt queue ctx done its own err
glendc
committed
resolve more comments from review
glendc
committed
update link to new benchmark repo
glendc
committed
go mod tidy (remove pidusage dep)
glendc
committed

Commits on Feb 13, 2023

handle more review comments
glendc
committed
fix linter error
glendc
committed

Commits on Feb 14, 2023

address some more review comments
glendc
committed

Commits on Feb 19, 2023

improve webrtc by resolving more review comments
glendc
committed
further clean up code
glendc
committed
remove wg from stream
glendc
committed

Commits on Feb 21, 2023

add more comments and resolve MR review
glendc
committed
merge stream back into one
glendc
committed

Commits on Feb 22, 2023

Commits on Feb 23, 2023

remove shorter read in packetsQueue::pop
glendc
committed
bugfix muxed_connection.go
glendc
committed
fix dialMatcher selection + test
glendc
committed
skip failing tests to get an idea of what is failing
glendc
committed

Commits on Feb 24, 2023

fix broken TestTransportWebRTC_Read test
glendc
committed

Commits on Feb 25, 2023

fix last remaining failing unit tests
glendc
committed
fix unit test (linux) + linter (check)
glendc
committed
fix linter (check): unused var
glendc
committed

Commits on Feb 26, 2023

Commits on Mar 1, 2023

apply some feeback alreay
glendc
committed
clean up code further and apply feedback
glendc
committed
use go-msgio to write prefixe msg on wire
glendc
committed
add fuzz test for hex interperse util
glendc
committed

Commits on Mar 2, 2023

Commits on Mar 3, 2023

resolve more review comments
glendc
committed
max in flight conns with a single worker
glendc
committed
handle previously ignored errors
glendc
committed
improve testing and code for webrtc
glendc
committed
more hex tests
glendc
committed
move awaitPeerConnectionOpen out internal to avoid needing log there
glendc
committed
fix lint checks
glendc
committed

Commits on Mar 9, 2023

address more review comments
glendc
committed
Merge remote-tracking branch 'origin/master' into feat/webrtc
glendc
committed
remove priv key from connection (no longer needed)
glendc
committed
address more comments
glendc
committed

Commits on Mar 11, 2023

address more comments
glendc
committed

Commits on Mar 14, 2023

drop custom CondVar sync primitive
glendc
committed
move GetDataChannel to private function in root webrtc pkg
glendc
committed
add comment to explain why connection internal setters are required
glendc
committed
add high level webrtc test
glendc
committed
use IncludeLoopbackCandidate(true) for webrtc's pion
glendc
committed

Commits on Mar 15, 2023

Update p2p/transport/webrtc/stream.go

GlenDC
and
marten-seemann
authored
do not make ICE timeouts configurable for WebRTC
glendc
committed
Merge remote-tracking branch 'origin/master' into feat/webrtc
glendc
committed
fix more comments
glendc
committed

Commits on Mar 17, 2023

use tpt.Trasnport in webrtc/connection.go, preparing it for M3
glendc
committed
address reviews and improve code further as such
glendc
committed
correctly indicate FD when opening outbound conn
glendc
committed
add TODOs of open problems with WebRTC (not inclusive)
glendc
committed
more TODOs
glendc
committed

Commits on Mar 23, 2023

Merge remote-tracking branch 'origin' into feat/webrtc
glendc
committed
add more transport tests for WebRTC
glendc
committed
support webrtc as default transport and in integration transport test
glendc
committed

Commits on Mar 30, 2023

Commits on Mar 31, 2023

rename /webrtc to /p2p-webrtc-direct
glendc
committed
make unit tests webrtc transport pass
glendc
committed
fix TODO: remove assumption that stream ID won't always exist yet
glendc
committed
add explanation for SetIncludeLoopbackCandidate (transport)
glendc
committed
use gater before making a new connection (fix TODO)
glendc
committed
go mod tidy
glendc
committed
fix listener (TODO): improve rate limit design
glendc
committed
address remaining review comments
glendc
committed
improve code further + fix tests
glendc
committed
implement more io READ guards
glendc
committed

Commits on Apr 1, 2023

remove pre-alloc of 16KiB
glendc
committed
fix mistake in edit
glendc
committed

Commits on Apr 7, 2023

passing unit and integration tests
ckousik
committed

Commits on Apr 10, 2023

Merge pull request #1 from ckousik/feat/webrtc
GlenDC
authored
merge master
glendc
committed
re-generate message.pb.go
glendc
committed
fix gen pb go
glendc
committed
add received data to integration test error
glendc
committed