tls: use ALPN to negotiate the stream multiplexer#1772
Merged
julian88110 merged 17 commits intomasterfrom Oct 7, 2022
Merged
Conversation
Contributor
marten-seemann
left a comment
marten-seemann
left a comment
There was a problem hiding this comment.
I like that this touches a lot less files than the previous iteration!
Co-authored-by: Marten Seemann <martenseemann@gmail.com>
Contributor
marten-seemann
left a comment
marten-seemann
left a comment
There was a problem hiding this comment.
This is looking really good. A couple of nits, mostly Go stylistic stuff.
This was referenced Sep 30, 2022
marten-seemann
changed the title
Contributor
marten-seemann
left a comment
marten-seemann
left a comment
There was a problem hiding this comment.
3 super tiny nits, then we should be good to go!
Contributor
marten-seemann
left a comment
marten-seemann
left a comment
There was a problem hiding this comment.
One super minor nit in the test, then this should be good to go.
marten-seemann
approved these changes
Oct 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked by #1751
This is an implementation of TLS based muxer selection proposed in #426 and specified in spec #446