noise: switch to proto2, use the new NoiseExtensions protobuf#1762
Merged
marten-seemann merged 2 commits intomasterfrom Sep 20, 2022
Merged
noise: switch to proto2, use the new NoiseExtensions protobuf#1762marten-seemann merged 2 commits intomasterfrom
marten-seemann merged 2 commits intomasterfrom
Conversation
10 tasks
marten-seemann
force-pushed
the
noise-extensions
branch
from
8008349 to
5b92d25
Compare
marten-seemann
commented
Sep 19, 2022
| @@ -1,8 +1,12 @@ | |||
| syntax = "proto3"; | |||
| syntax = "proto2"; | |||
Contributor
Author
There was a problem hiding this comment.
I confirmed that a node running v0.22.0 can connect to a node using this branch, and vice versa.
MarcoPolo
reviewed
Sep 20, 2022
MarcoPolo
approved these changes
Sep 20, 2022
marten-seemann
force-pushed
the
noise-extensions
branch
from
32248a8 to
edf655a
Compare
julian88110
pushed a commit
that referenced
this pull request
Oct 11, 2022
noise: switch to proto2, use the new NoiseExtensions protobuf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the NoiseExtensions protobuf as specified in libp2p/specs#453.