noise: don't fail handshake when early data is received without handler#1746
Merged
marten-seemann merged 1 commit intomasterfrom Sep 13, 2022
Merged
Conversation
julian88110
approved these changes
Sep 12, 2022
Contributor
julian88110
left a comment
julian88110
left a comment
There was a problem hiding this comment.
Marten, Thanks for changing this, yes the Muxer selection feature relies on this behavior for backward compatibility.
Contributor
Author
|
I just realized that libp2p/specs#446 uses the second and the third flight, so technically this would break. It's a good idea to be not fail the handshake in case we ever want to add some data to the first flight though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just realized that the change we introduced in #1728 would preclude us from rolling out the change that @julian88110 is working on (see libp2p/specs#446). This means that this PR must make it into v0.23.0.