Skip to content
This repository was archived by the owner on Sep 30, 2025. It is now read-only.

Conversation

@dhuseby
Copy link
Contributor

@dhuseby dhuseby commented Feb 21, 2025

Signed-off-by: Dave Grantham dwg@linuxprogrammer.org

Summary

This does the following:

  • Establishes the universal-connectivity Maintainers for maintainers that are not also in another libp2p maintainer team
  • Adds the py-libp2p Maintainers as universal-connectivity maintainers
  • Removes w3dt-stewards from py-libp2p maintainership because we have an independent active team of maintainers now

Why do you need this?

The universal connectivity app is getting a version in Python. There's also energy going into maintaining the go/js/rust versions as well. By adding new maintainers we can start chewing through the PR backlog.

What else do we need to know?

The universal connectivity app is being used to teach libp2p workshops at many different conferences this year. There is a lot of work being done to create learning materials and to get the implementations working well.

DRI: myself

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

Signed-off-by: Dave Grantham <dwg@linuxprogrammer.org>
@dhuseby dhuseby requested a review from a team as a code owner February 21, 2025 16:44
@dhuseby dhuseby requested a review from a team February 21, 2025 16:44
@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2025

The following access changes will be introduced as a result of applying the plan:

Access Changes
User 2color:
  - will lose admin permission to py-libp2p
  - will lose admin permission to py-libp2p-slog
  - will lose admin permission to py-libp2p-xor
User achingbrain:
  - will have the permission to py-libp2p change from admin to pull
  - will have the permission to py-libp2p-slog change from admin to pull
  - will have the permission to py-libp2p-xor change from admin to pull
User aschmahmann:
  - will lose admin permission to py-libp2p
  - will lose admin permission to py-libp2p-slog
  - will lose admin permission to py-libp2p-xor
User dhuseby:
  - will have the permission to py-libp2p change from admin to maintain
  - will have the permission to py-libp2p-slog change from admin to maintain
  - will have the permission to py-libp2p-xor change from admin to maintain
  - will have the permission to universal-connectivity change from pull to admin
User galargh:
  - will lose admin permission to py-libp2p
  - will lose admin permission to py-libp2p-slog
  - will lose admin permission to py-libp2p-xor
User guillaumemichel:
  - will lose admin permission to py-libp2p
  - will lose admin permission to py-libp2p-slog
  - will lose admin permission to py-libp2p-xor
User jorropo:
  - will lose admin permission to py-libp2p
  - will lose admin permission to py-libp2p-slog
  - will lose admin permission to py-libp2p-xor
User laurentsenta:
  - will lose admin permission to py-libp2p
  - will lose admin permission to py-libp2p-slog
  - will lose admin permission to py-libp2p-xor
User lidel:
  - will lose admin permission to py-libp2p
  - will lose admin permission to py-libp2p-slog
  - will lose admin permission to py-libp2p-xor
User marcopolo:
  - will lose admin permission to py-libp2p
  - will lose admin permission to py-libp2p-slog
  - will lose admin permission to py-libp2p-xor
User mxinden:
  - will lose admin permission to py-libp2p
  - will lose admin permission to py-libp2p-slog
  - will lose admin permission to py-libp2p-xor
User p-shahi:
  - will have the permission to py-libp2p change from admin to pull
  - will have the permission to py-libp2p-slog change from admin to pull
  - will have the permission to py-libp2p-xor change from admin to pull
User pacrob:
  - will gain maintain permission to universal-connectivity
User seetadev:
  - will gain maintain permission to universal-connectivity
User stebalien:
  - will have the permission to py-libp2p change from admin to pull
  - will have the permission to py-libp2p-slog change from admin to pull
  - will have the permission to py-libp2p-xor change from admin to pull
User sukunrt:
  - will lose admin permission to py-libp2p
  - will lose admin permission to py-libp2p-slog
  - will lose admin permission to py-libp2p-xor
User yiannisbot:
  - will lose admin permission to py-libp2p
  - will lose admin permission to py-libp2p-slog
  - will lose admin permission to py-libp2p-xor
User kentbull:
  - will join the organization as a [object Object] (remind them to accept the email invitation)
  - will gain maintain permission to universal-connectivity

@github-actions
Copy link
Contributor

github-actions bot commented Feb 21, 2025

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

libp2p

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create
  - destroy

Terraform will perform the following actions:

  # github_membership.this["kentbull"] will be created
  + resource "github_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + username = "kentbull"
    }

  # github_repository_collaborator.this["universal-connectivity:dhuseby"] will be created
  + resource "github_repository_collaborator" "this" {
      + id                          = (known after apply)
      + invitation_id               = (known after apply)
      + permission                  = "admin"
      + permission_diff_suppression = false
      + repository                  = "universal-connectivity"
      + username                    = "dhuseby"
    }

  # github_team.this["universal-connectivity maintainers"] will be created
  + resource "github_team" "this" {
      + create_default_maintainer = false
      + description               = "Maintainers of universal-connectivity that are not maintainers of other libp2p implementations"
      + etag                      = (known after apply)
      + id                        = (known after apply)
      + members_count             = (known after apply)
      + name                      = "universal-connectivity Maintainers"
      + node_id                   = (known after apply)
      + privacy                   = "closed"
      + slug                      = (known after apply)
    }

  # github_team_membership.this["universal-connectivity maintainers:dhuseby"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "maintainer"
      + team_id  = (known after apply)
      + username = "dhuseby"
    }

  # github_team_membership.this["universal-connectivity maintainers:kentbull"] will be created
  + resource "github_team_membership" "this" {
      + etag     = (known after apply)
      + id       = (known after apply)
      + role     = "member"
      + team_id  = (known after apply)
      + username = "kentbull"
    }

  # github_team_repository.this["py-libp2p maintainers:universal-connectivity"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "maintain"
      + repository = "universal-connectivity"
      + team_id    = "9705831"
    }

  # github_team_repository.this["universal-connectivity maintainers:universal-connectivity"] will be created
  + resource "github_team_repository" "this" {
      + etag       = (known after apply)
      + id         = (known after apply)
      + permission = "maintain"
      + repository = "universal-connectivity"
      + team_id    = (known after apply)
    }

  # github_team_repository.this["w3dt-stewards:py-libp2p"] will be destroyed
  # (because key ["w3dt-stewards:py-libp2p"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"f9e1ac78b5783fa1d3beacd773723839d4c86cbaf944e430358a1789c2bfe971\"" -> null
      - id         = "4657013:py-libp2p" -> null
      - permission = "admin" -> null
      - repository = "py-libp2p" -> null
      - team_id    = "4657013" -> null
    }

  # github_team_repository.this["w3dt-stewards:py-libp2p-slog"] will be destroyed
  # (because key ["w3dt-stewards:py-libp2p-slog"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"5a880d0d5a3f1dd270788ef4741712d734d1755f002c6e30bb3fca502fdc725c\"" -> null
      - id         = "4657013:py-libp2p-slog" -> null
      - permission = "admin" -> null
      - repository = "py-libp2p-slog" -> null
      - team_id    = "4657013" -> null
    }

  # github_team_repository.this["w3dt-stewards:py-libp2p-xor"] will be destroyed
  # (because key ["w3dt-stewards:py-libp2p-xor"] is not in for_each map)
  - resource "github_team_repository" "this" {
      - etag       = "W/\"3e8dffba2e3d7984a441dd749c0695df998035f1d2b6e0cf0cf1af905411ae2a\"" -> null
      - id         = "4657013:py-libp2p-xor" -> null
      - permission = "admin" -> null
      - repository = "py-libp2p-xor" -> null
      - team_id    = "4657013" -> null
    }

Plan: 7 to add, 0 to change, 3 to destroy.

Copy link
Member

@galargh galargh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll check in with the shipyard about these changes

maintainer:
- dhuseby
member:
- kentbull
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, only organization members can be team members

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added kentbull to the org members list.

@galargh galargh merged commit 16431f1 into master Feb 24, 2025
6 checks passed
@p-shahi p-shahi deleted the universal-connectivity branch February 24, 2025 17:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants