Merged
Conversation
benpruitt
reviewed
Jan 2, 2026
Contributor
benpruitt
left a comment
There was a problem hiding this comment.
lgtm; thanks for pulling this together. A couple of minor requests:
- Can you add a module docstring to your tests module, conformant w/ the module docstring used in other test modules (https://github.com/libnano/primer3-py/tree/master/tests)?
- Rename the test module with a more directly descriptive name (e.g.,
test_str_rep_ifc_compat.py
Once we have this PR buttoned up, I'll spin a minor version release (we've got a couple of changes sitting on master that have yet to be incorporated into a release, all minor).
Contributor
Author
|
Hello, I have renamed the test module and added the docstring. |
benpruitt
approved these changes
Jan 6, 2026
Merged
Contributor
|
@uguraka thanks for your work on this feature -- we cut |
Contributor
Author
|
Happy to have contributed! Thank you for the review and for getting this released so quickly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue #164 by enabling objects with sequence representation in analysis functions.
Changes made:
_bytes()inprimer3/thermoanalysis.pyxto accept any object that implements__str__, not juststrorbytes.calc_tm()inprimer3/thermoanalysis.pyxto explicitly convert non-bytes objects to string before validation to preventTypeError.primer3/bindings.pyto reflect that objects are now accepted.tests/test_issue_164.pycovering both (calc_tm) and (calc_end_stability) paths.Verification:
tests/test_issue_164.pypasses successfully.strandbytesremains unchanged.