Skip to content

fix cmake warnings; bump libigl #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alecjacobson merged 1 commit into from
Apr 15, 2025
Merged

fix cmake warnings; bump libigl #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ option(LIBIGL_RESTRICTED_TRIANGLE "Build target igl_restricted::triangle" ON)
FetchContent_Declare(
libigl
GIT_REPOSITORY https://github.com/libigl/libigl.git
GIT_TAG a221faf1e4bd571529ca2101c08bc2458579b1da
GIT_TAG 788871103938ce92112714d11ea491e8e6b4d972
)
FetchContent_MakeAvailable(libigl)

Expand Down
5 changes: 4 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,10 @@ expected.

Install whichever version of Python from the [official website](https://www.python.org/downloads/) and then run:

/Library/Frameworks/Python.framework/Versions/[version]/bin/python -m pip install cibuildwheel

/Library/Frameworks/Python.framework/Versions/3.11/bin/python3.11 -m venv venv-official-3.11
source venv-official-3.11/bin/activate
python -m pip install cibuildwheel
CIBW_BUILD="cp311-*" python -m cibuildwheel --output-dir wheelhouse --platform macos

## Downloading all the artifacts
Expand Down
2 changes: 1 addition & 1 deletion cmake/Warnings.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
################################################################################
cmake_minimum_required(VERSION 2.8.12)
cmake_minimum_required(VERSION 3.5)
################################################################################
# See comments and discussions here:
# http://stackoverflow.com/questions/5088460/flags-to-enable-thorough-and-verbose-g-warnings
Expand Down
Loading