Merged
Conversation
| antioch_init_DATA = ${antioch_init_SOURCES} | ||
|
|
||
| #Define examples to actually be run | ||
| TESTS = |
Contributor
There was a problem hiding this comment.
Nuke this and the associated lines below it. This doesn't belong to the test suite.
Contributor
Author
There was a problem hiding this comment.
Leaving them. More tests is better than fewer, even if we're pretty sure they're redundant. We probably don't want to establish the expectation that examples also be regression tests, but we should leave open the option.
Contributor
|
Thanks @roystgnr, sorry for the hiccup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the problem I hit from #218
We'll probably need to rebase #226 on this.
I think "put everything in share/examples" is the most standard way to go, but I could be talked out of that; I'm willing to settle for any install behavior which does not include "error and die".