EGlib correction to vanishing molar concentrations#132
Open
SylvainPlessis wants to merge 4 commits intolibantioch:masterfrom
Open
EGlib correction to vanishing molar concentrations#132SylvainPlessis wants to merge 4 commits intolibantioch:masterfrom
SylvainPlessis wants to merge 4 commits intolibantioch:masterfrom
Conversation
a very small change to simplify (StateType is defined)
be constant-copied
Member
|
@SylvainPlessis did you ever notice any actual large sensitivity due to this issue? |
Contributor
Author
|
@pbauman, actually I've never play chemistry (transport, actually) in such conditions (almost pure). They did seem concerned about that in the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This concerns the diffusion calculations, it computes modified diffusion terms to ensure computational stability with respect to vanishing concentrations.
This is the EG lib way of doing it, documentation of EG lib is here.
I'd like some agreement on the choice of the value of epsilon before merging.