Skip to content

Comments

chore: remove R/methods-fragments.R (moved to PSMatch)#609

Merged
lgatto merged 1 commit intomasterfrom
methods-fragments
Apr 11, 2025
Merged

chore: remove R/methods-fragments.R (moved to PSMatch)#609
lgatto merged 1 commit intomasterfrom
methods-fragments

Conversation

@sgibb
Copy link
Collaborator

@sgibb sgibb commented Apr 10, 2025

After adapting to the new PSMatch::calculateFragments (with fixed_modifications instead of modifications) some unit tests in topdownr fail. In topdownr MSnbase::calculateFragments overwrites PSMatch::calculateFragments.
Unfortunately the syntax is slightly different, e.g. MSnbase knows nothing about fixed_modifications.

To reproduce this error, load MSnbase before PSMatch:

library("MSnbase")
library("PSMatch")
calculateFragments("AACE", fixed_modifications=NULL)
# Error in .local(sequence, ...) : 
#   unused argument (fixed_modifications = NULL)

MSnbase::calculateFragments's body is similar to PSMatch::calculateFragments's body. The only difference is the verbose = isMsnbaseVerbose() argument/setting.
So maybe it would be useful to remove this file? (or adjust to PSMatch's arguments).

@sgibb sgibb requested a review from lgatto April 10, 2025 21:54
@lgatto
Copy link
Owner

lgatto commented Apr 11, 2025

Indeed. I am surprised that there's still such a function in MSnbase.

@lgatto lgatto merged commit 852fcde into master Apr 11, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants