calcurse-holiday to create holiday events for irregular dates#357
Open
atticus-sullivan wants to merge 4 commits intolfos:pufrom
Open
calcurse-holiday to create holiday events for irregular dates#357atticus-sullivan wants to merge 4 commits intolfos:pufrom
atticus-sullivan wants to merge 4 commits intolfos:pufrom
Conversation
For the functionality see `-h` and the 'README.md'. I think this is useful since it fills the gap for creating events for holiday days which dates are based on quite complicated functions like Eastesunday.
lfos
force-pushed
the
pu
branch
14 times, most recently
from
25a7cb4 to
f41955e
Compare
lfos
force-pushed
the
pu
branch
2 times, most recently
from
d6eb6e7 to
d81b00c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most things should be stated in the first commit and in the README.md
As I'm new in this thing, I've got a question:
automakeif steps are required in this area it would be very kind if you could give hints on what to do.I've tried to write clean code, but if I've violated some guidelines you have please tell me.
Notes:
configparserfor the config files (which in my case would be the holiday.yaml file). I've usedyamlsince I know this and since it's pretty easy to have lists to cycle one.For the sake of uniform configs and to reduce dependendies, I'm willing to switch. I'd just be interested in how you'd realize these sort of config with
configparser(I pretty much like the ability that keys can have whitespaces in yaml...)textwrapis used. Do you think this would be appropriate here too for the output on the console?