add upkeep method to AsyncSession#640
Open
kadamprashant1 wants to merge 1 commit intolexiforest:mainfrom
Open
Conversation
Owner
|
Since there is no multi interface for upkeep. I guess this is the only way to send ping frames, I will have some style fixes and then merge. Thanks. |
Author
|
Thanks @lexiforest! |
|
Any progress on this? |
Contributor
|
I'd suggest this approach rather than processing handles concurrently. It's safer against pool starvation since each handle is returned immediately after upkeep and it can also be used as a standalone utility: async def upkeep(session: curl_cffi.AsyncSession) -> list[int]:
"""
Performs connection upkeep for all idle connections in the pool.
"""
session._check_session_closed()
results = []
curls: List[curl_cffi.Curl] = []
# Drain pool
while True:
try:
curls.append(session.pool.get_nowait())
except asyncio.QueueEmpty:
break
# Upkeep and return immediately
for curl in curls:
if curl:
results.append(curl.upkeep())
session.pool.put_nowait(curl)
return resultsSince |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces the upkeep() asynchronous method to the AsyncSession class, bringing feature parity with the synchronous Session class and enhancing its capabilities for long-running applications.