Open
Conversation
|
|
I think the -2 is needed to still prevent overflowing in some cases: https://svelte.dev/repl/f510622fc2964815909e5f0ba553088e?version=3.50.0 Here's a link to a svelte repl: if you check or uncheck the checbox above you can swap between the two implementations and you can see commenting the line 31 make the action behave differently from the original package. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bit of redundancy in the code:
iandsizeare nearly identicaloverflowisn't necessary: it starts at false,whileexecutes at least once, it assigns function result to a value then check for falsiness – instead could check function result directly inwhileI am unsure why
size = i - 2was needed; ififits then why decrements by 2 pixels?Great library, could def use it in our team