Open
Conversation
- select bootstrap version via KEG_BOOTSTRAP_MAJOR_VERSION config (default 5) - select whether bootstrap is used at all via KEG_TEMPLATE_FLAVOR config (default bootstrap) - use tomselect for bootstrap 5+, in place of select2 (to remove jQuery dependency) refs #188
guruofgentoo
force-pushed
the
188-bootstrap-5
branch
from
298d7c8 to
8e47e4c
Compare
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
=======================================
Coverage 96.17% 96.17%
=======================================
Files 33 33
Lines 3840 3840
=======================================
Hits 3693 3693
Misses 147 147 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
|
@guruofgentoo any reason this didn't end up getting merged? |
Member
Author
|
IIRC it was just due to the BC break at the time, and then fell off the radar. I had forgotten this was out there. We should bring it in though - it makes dealing with the different Bootstrap versions much more explicit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch to Bootstrap 5 by default, add two config keys to make selecting bootstrap version for template support a bit easier.
KEG_BOOTSTRAP_MAJOR_VERSIONconfig (default 5)KEG_TEMPLATE_FLAVORconfig (default bootstrap)refs #188
BC BREAK Apps that want to stay on Bootstrap 4 will need to set
KEG_BOOTSTRAP_MAJOR_VERSIONto 4. Apps could also begin extending thehorizontal.htmlform template instead ofhorizontal-b4.html, but that change is not required.