WIP: Lettuce MPI by McBs · Pull Request #123 · lettucecfd/lettuce

McBs · 2022-04-21T10:29:40Z

This PR is still in progress.

Validation
TGV3D - Dissipation rate - calculated on 4xV100
Re 100 - Still running
Re 200 - Res 250³
Re 400 - Res 250³
Re 800 - Res 250³
Re 1600 - Still running
Re 3000 - Still running
Re 5000 - Still running
tgv3d_dissipation.pdf

- torchdd_domain - torchdd_decomposition - lettuce adjustments #simulation#flow

pep8speaks · 2022-04-21T10:29:47Z

Hello @McBs! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file examples/WIP/build_decomposition.py:

Line 41:31: E128 continuation line under-indented for visual indent
Line 42:31: E128 continuation line under-indented for visual indent
Line 43:31: E128 continuation line under-indented for visual indent
Line 44:31: E128 continuation line under-indented for visual indent
Line 47:31: E128 continuation line under-indented for visual indent
Line 48:31: E128 continuation line under-indented for visual indent
Line 49:31: E128 continuation line under-indented for visual indent
Line 50:31: E128 continuation line under-indented for visual indent
Line 55:28: E231 missing whitespace after ','
Line 55:32: E231 missing whitespace after ','
Line 55:50: E231 missing whitespace after ','
Line 55:54: E231 missing whitespace after ','
Line 58:80: E501 line too long (86 > 79 characters)
Line 60:80: E501 line too long (107 > 79 characters)

In the file examples/WIP/build_flow.py:

Line 11:14: E225 missing whitespace around operator
Line 11:19: E225 missing whitespace around operator
Line 25:20: W292 no newline at end of file

In the file examples/WIP/mpi_tgv3d.py:

Line 9:9: E261 at least two spaces before inline comment
Line 9:10: E262 inline comment should start with '# '
Line 28:80: E501 line too long (87 > 79 characters)
Line 38:39: E231 missing whitespace after ','
Line 38:41: E231 missing whitespace after ','
Line 43:31: E128 continuation line under-indented for visual indent
Line 44:31: E128 continuation line under-indented for visual indent
Line 45:31: E128 continuation line under-indented for visual indent
Line 46:31: E128 continuation line under-indented for visual indent
Line 51:17: E231 missing whitespace after ','
Line 51:42: E231 missing whitespace after ','
Line 51:62: E231 missing whitespace after ','
Line 51:71: E231 missing whitespace after ','
Line 51:80: E501 line too long (121 > 79 characters)
Line 51:84: E231 missing whitespace after ','
Line 53:80: E501 line too long (81 > 79 characters)
Line 56:80: E501 line too long (102 > 79 characters)
Line 59:80: E501 line too long (84 > 79 characters)
Line 64:19: E231 missing whitespace after ','

In the file lettuce/boundary.py:

Line 35:80: E501 line too long (119 > 79 characters)
Line 59:80: E501 line too long (86 > 79 characters)
Line 67:80: E501 line too long (91 > 79 characters)

In the file lettuce/flows/flow.py:

Line 33:80: E501 line too long (96 > 79 characters)
Line 36:42: E225 missing whitespace around operator
Line 50:80: E501 line too long (82 > 79 characters)
Line 51:80: E501 line too long (80 > 79 characters)
Line 52:80: E501 line too long (82 > 79 characters)
Line 79:80: E501 line too long (86 > 79 characters)
Line 80:80: E501 line too long (99 > 79 characters)
Line 81:80: E501 line too long (91 > 79 characters)
Line 83:80: E501 line too long (83 > 79 characters)
Line 87:80: E501 line too long (86 > 79 characters)
Line 88:80: E501 line too long (92 > 79 characters)
Line 91:80: E501 line too long (111 > 79 characters)
Line 95:80: E501 line too long (96 > 79 characters)
Line 97:80: E501 line too long (87 > 79 characters)
Line 104:1: E303 too many blank lines (4)
Line 108:80: E501 line too long (98 > 79 characters)
Line 116:80: E501 line too long (82 > 79 characters)
Line 126:80: E501 line too long (102 > 79 characters)
Line 138:1: W391 blank line at end of file

In the file lettuce/flows/taylorgreen.py:

Line 52:80: E501 line too long (95 > 79 characters)

In the file lettuce/simulation.py:

Line 40:80: E501 line too long (86 > 79 characters)
Line 41:80: E501 line too long (81 > 79 characters)
Line 42:80: E501 line too long (88 > 79 characters)

In the file tests/conftest.py:

Line 79:1: E302 expected 2 blank lines, found 1

In the file tests/test_domain.py:

Line 7:1: E302 expected 2 blank lines, found 1
Line 25:21: E712 comparison to True should be 'if cond is True:' or 'if cond:'
Line 27:21: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
Line 34:80: E501 line too long (80 > 79 characters)
Line 77:80: E501 line too long (86 > 79 characters)
Line 104:80: E501 line too long (114 > 79 characters)
Line 119:24: E231 missing whitespace after ','
Line 119:31: E231 missing whitespace after ','
Line 122:1: E302 expected 2 blank lines, found 1
Line 132:80: E501 line too long (90 > 79 characters)
Line 134:37: E231 missing whitespace after ','
Line 134:39: E231 missing whitespace after ','
Line 139:1: W391 blank line at end of file

In the file torchdd/__init__.py:

Line 5:1: E265 block comment should start with '# '
Line 5:80: E501 line too long (93 > 79 characters)
Line 5:80: E501 line too long (93 > 79 characters)
Line 5:94: W292 no newline at end of file
Line 5:94: W292 no newline at end of file
Line 5:94: W292 no newline at end of file

In the file torchdd/communication.py:

Line 4:1: E265 block comment should start with '# '
Line 6:1: E302 expected 2 blank lines, found 1
Line 11:13: W292 no newline at end of file

In the file torchdd/ddtensor.py:

Line 34:80: E501 line too long (101 > 79 characters)
Line 51:1: W391 blank line at end of file

In the file torchdd/decompostion.py:

Line 26:1: E302 expected 2 blank lines, found 1
Line 46:43: E261 at least two spaces before inline comment
Line 46:44: E262 inline comment should start with '# '
Line 88:14: E111 indentation is not a multiple of four
Line 88:14: E117 over-indented
Line 88:80: E501 line too long (107 > 79 characters)
Line 115:80: E501 line too long (92 > 79 characters)
Line 123:32: E225 missing whitespace around operator
Line 124:80: E501 line too long (162 > 79 characters)
Line 124:155: E225 missing whitespace around operator
Line 125:80: E501 line too long (138 > 79 characters)
Line 126:17: E124 closing bracket does not match visual indentation
Line 128:54: E231 missing whitespace after ','
Line 128:80: E501 line too long (82 > 79 characters)
Line 145:39: E251 unexpected spaces around keyword / parameter equals
Line 145:41: E251 unexpected spaces around keyword / parameter equals
Line 155:80: E501 line too long (115 > 79 characters)
Line 160:80: E501 line too long (94 > 79 characters)
Line 173:28: E231 missing whitespace after ','
Line 173:58: E231 missing whitespace after ','
Line 177:80: E501 line too long (85 > 79 characters)
Line 181:38: E251 unexpected spaces around keyword / parameter equals
Line 181:40: E251 unexpected spaces around keyword / parameter equals
Line 183:9: E265 block comment should start with '# '
Line 183:80: E501 line too long (119 > 79 characters)
Line 186:80: E501 line too long (89 > 79 characters)
Line 187:54: E231 missing whitespace after ','
Line 187:56: E231 missing whitespace after ','
Line 203:9: E265 block comment should start with '# '
Line 206:1: E302 expected 2 blank lines, found 1
Line 233:80: E501 line too long (111 > 79 characters)
Line 238:80: E501 line too long (106 > 79 characters)
Line 239:80: E501 line too long (99 > 79 characters)
Line 240:80: E501 line too long (81 > 79 characters)
Line 243:80: E501 line too long (89 > 79 characters)
Line 244:80: E501 line too long (114 > 79 characters)
Line 245:80: E501 line too long (90 > 79 characters)
Line 248:80: E501 line too long (90 > 79 characters)
Line 249:9: E265 block comment should start with '# '
Line 251:80: E501 line too long (80 > 79 characters)
Line 253:80: E501 line too long (86 > 79 characters)
Line 254:80: E501 line too long (93 > 79 characters)
Line 257:27: E231 missing whitespace after ','
Line 257:80: E501 line too long (92 > 79 characters)
Line 260:9: E303 too many blank lines (2)
Line 262:1: E302 expected 2 blank lines, found 1
Line 277:80: E501 line too long (126 > 79 characters)
Line 278:80: E501 line too long (99 > 79 characters)
Line 280:80: E501 line too long (88 > 79 characters)
Line 285:17: E303 too many blank lines (2)
Line 285:80: E501 line too long (88 > 79 characters)
Line 295:49: W292 no newline at end of file

In the file torchdd/domain.py:

Line 9:1: E265 block comment should start with '# '
Line 16:1: E302 expected 2 blank lines, found 1
Line 30:80: E501 line too long (108 > 79 characters)
Line 64:80: E501 line too long (108 > 79 characters)
Line 80:80: E501 line too long (83 > 79 characters)
Line 81:80: E501 line too long (85 > 79 characters)
Line 101:45: E231 missing whitespace after ','
Line 102:45: E231 missing whitespace after ','
Line 108:23: E222 multiple spaces after operator
Line 134:80: E501 line too long (108 > 79 characters)
Line 135:80: E501 line too long (101 > 79 characters)
Line 137:80: E501 line too long (93 > 79 characters)
Line 138:80: E501 line too long (81 > 79 characters)
Line 139:80: E501 line too long (83 > 79 characters)
Line 147:5: E303 too many blank lines (2)
Line 153:80: E501 line too long (100 > 79 characters)
Line 165:80: E501 line too long (92 > 79 characters)
Line 166:80: E501 line too long (83 > 79 characters)
Line 171:80: E501 line too long (94 > 79 characters)
Line 171:90: E251 unexpected spaces around keyword / parameter equals
Line 175:80: E501 line too long (89 > 79 characters)
Line 175:85: E251 unexpected spaces around keyword / parameter equals
Line 183:80: E501 line too long (118 > 79 characters)
Line 189:80: E501 line too long (84 > 79 characters)
Line 197:80: E501 line too long (110 > 79 characters)
Line 198:80: E501 line too long (96 > 79 characters)
Line 200:80: E501 line too long (82 > 79 characters)
Line 206:5: E303 too many blank lines (2)
Line 206:80: E501 line too long (108 > 79 characters)
Line 207:80: E501 line too long (133 > 79 characters)
Line 208:64: E231 missing whitespace after ','
Line 208:80: E501 line too long (114 > 79 characters)
Line 209:64: E231 missing whitespace after ','
Line 209:80: E501 line too long (114 > 79 characters)
Line 210:80: E501 line too long (141 > 79 characters)
Line 211:80: E501 line too long (88 > 79 characters)
Line 212:51: E261 at least two spaces before inline comment
Line 212:51: E262 inline comment should start with '# '
Line 212:80: E501 line too long (128 > 79 characters)
Line 220:5: E303 too many blank lines (2)
Line 224:5: E303 too many blank lines (2)
Line 224:80: E501 line too long (98 > 79 characters)
Line 227:80: E501 line too long (83 > 79 characters)
Line 231:80: E501 line too long (88 > 79 characters)
Line 234:80: E501 line too long (150 > 79 characters)
Line 234:113: E231 missing whitespace after ','
Line 236:80: E501 line too long (92 > 79 characters)
Line 242:80: E501 line too long (88 > 79 characters)
Line 252:80: E501 line too long (88 > 79 characters)
Line 261:32: E261 at least two spaces before inline comment
Line 261:33: E262 inline comment should start with '# '
Line 266:5: E303 too many blank lines (2)
Line 267:80: E501 line too long (86 > 79 characters)
Line 270:80: E501 line too long (141 > 79 characters)
Line 271:1: W391 blank line at end of file

In the file torchdd/mpi.py:

Line 11:1: W391 blank line at end of file

McBs added 3 commits April 21, 2022 10:54

Add MPI decomposition features

b377911

- torchdd_domain - torchdd_decomposition - lettuce adjustments #simulation#flow

Extend test_domain

26d1437

Add prototype examples #wip

6eeadfd

McBs requested a review from Olllom April 22, 2022 07:46

McBs marked this pull request as draft February 6, 2024 16:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

WIP: Lettuce MPI#123

WIP: Lettuce MPI#123
McBs wants to merge 3 commits intolettucecfd:masterfrom
McBs:mpi_wpi

McBs commented Apr 21, 2022 •

edited

Loading

Uh oh!

pep8speaks commented Apr 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Comments

Conversation

McBs commented Apr 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pep8speaks commented Apr 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

McBs commented Apr 21, 2022 •

edited

Loading