Gravity fix #13
Open
Gravity fix #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…toughing the ground style: made indentation mode consistent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gravity fix
Bug
There is a bug with the way gravity is applied to objects.
In the
gravityfunction of thephysics.luascript if one object is continuously touching the ground, it can prevent other objects from receiving velocity updates.The bug is probably present in other branches of the project, presumably from
Lesson05.Fix
Restructured the branch so it does not stop query processing.
Minor Changes
Not sure if this was intentional or not, but indentation was inconsistent, changing between tabs and spaces mid-block.
I know the repo was never supposed to be an exemplary piece of code, and I am not critiquing it in any way.
It's just that VSCode was forcing consistent indentation style on me, and I was too lazy to disable the feature.