Condition wait #5
Conversation
time.sleep(n) is a kernel call that pauses the entire Python interpreter, Python threads a virtual. Using condition.wait(n) lets the other threads execute while waiting, this bypasses the GIL (global interpreter lock).
Added workflow to enable tests after commit.
…ime.sleep to avoid Global Interpreter Lock (GIL).
…ead of time.sleep to avoid Global Interpreter Lock (GIL).
|
Thanks! Any chance that you may rebase it on the latest commit in the |
retry/api.py
Outdated
| fail_callback(e) | ||
|
|
||
| with ConditionRelease(condition) as _condition: | ||
| print('_condtion:', _condition) |
There was a problem hiding this comment.
Does it really need to print to stdout or did you want to add some logging?
retry/api.py
Outdated
| class ConditionRelease(object): | ||
| def __init__(self, c): | ||
| self.c = c | ||
| def __enter__(self): | ||
| self.c.acquire() | ||
| return self | ||
| def wait(self, n): | ||
| self.c.wait(n) | ||
| def __exit__(self, exc_type, exc_value, exc_tb): | ||
| self.c.release() |
There was a problem hiding this comment.
Can a contextlib.contextmanager be used instead? Would it make it simpler?
There was a problem hiding this comment.
Will change the context manager class, but contextmanager decorator alone is not something that seems fullproof enough. This context manager class will make code easier to read.
removed some stdout prints, changed the context class.
| @@ -0,0 +1,37 @@ | |||
| # This workflow will install Python dependencies, run tests and lint with a single version of Python | |||
There was a problem hiding this comment.
.github/workflows/pythonapp.yml - it seem like this file should not be here
README.rst
Outdated
| :param condition: threading.Condition or multiprocessing.Condition or any construct that | ||
| has acquire(), release() and wait(n) |
There was a problem hiding this comment.
README.rst was superceded by README.md
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 2.58%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
|
I'd like to withdraw the request, this link explain why it is not needed: Thanks. |
3 participants
Pulled the code from leshchenko1979/reretry, modified api.py and test_retry.py so that only the condition_wait changes are added.
Done to comply with request on this link: invl#48 (comment)
Thanks.