Skip to content

Conversation

@leshchenko1979
Copy link
Owner

No description provided.

@sourcery-ai
Copy link

sourcery-ai bot commented May 8, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.18%.

Quality metrics Before After Change
Complexity 2.94 ⭐ 2.79 ⭐ -0.15 👍
Method Length 38.05 ⭐ 38.26 ⭐ 0.21 👎
Working memory 4.96 ⭐ 5.02 ⭐ 0.06 👎
Quality 83.09% 83.27% 0.18% 👍
Other metrics Before After Change
Lines 389 416 27
Changed files Quality Before Quality After Quality Change
perscache/cache.py 70.57% 🙂 70.32% 🙂 -0.25% 👎
tests/test_main.py 92.66% ⭐ 92.42% ⭐ -0.24% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
perscache/cache.py Cache.cache 16 🙂 186 😞 8 🙂 48.91% 😞 Try splitting into smaller methods
perscache/cache.py Cache.cache.decorator 11 🙂 170 😞 8 🙂 54.58% 🙂 Try splitting into smaller methods
perscache/cache.py Cache.get_key 2 ⭐ 52 ⭐ 10 😞 74.17% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov-commenter
Copy link

codecov-commenter commented May 8, 2022

Codecov Report

Merging #7 (646a470) into master (d7add1d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
+ Coverage   97.34%   97.36%   +0.02%     
==========================================
  Files           5        5              
  Lines         188      190       +2     
==========================================
+ Hits          183      185       +2     
  Misses          5        5              
Impacted Files Coverage Δ
perscache/cache.py 98.68% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7add1d...646a470. Read the comment docs.

@leshchenko1979
Copy link
Owner Author

Need to clarify a use case behind this -- not sure if this will not just complicate things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants