fix: make -u option work again for add-from-file and update-from-file commands #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… commands Callers of add_notes_from_file in cli.py did not consider the new argument respect_note_ids as the second to last argument. Therefore, update_file was wrongly passed into respect_note_ids and not update_origin_file. This lead to the file never being updated. Changing the argument order fixes this.
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callers of
add_notes_from_filein cli.py did not consider the new argumentrespect_note_idsas the second to last argument.Therefore,
update_filewas wrongly passed intorespect_note_idsand notupdate_origin_file. This lead to the file never being updated. Changing the argument order fixes this.