feat(generator): check if glob pattern is valid#91
Merged
lerouxrgd merged 1 commit intolerouxrgd:masterfrom Jan 14, 2026
Merged
feat(generator): check if glob pattern is valid#91lerouxrgd merged 1 commit intolerouxrgd:masterfrom
lerouxrgd merged 1 commit intolerouxrgd:masterfrom
Conversation
saiintbrisson
approved these changes
Jan 14, 2026
lffg
approved these changes
Jan 14, 2026
|
Great job |
CaaioSB
approved these changes
Jan 14, 2026
alskenobi
approved these changes
Jan 14, 2026
alskenobi
approved these changes
Jan 14, 2026
leo-def
approved these changes
Jan 14, 2026
This patch adds a validation that checks if the glob pattern found any files.
Owner
|
Thanks for the PR ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds a validation that checks if the glob pattern found any files.
That's a validation that does make sense for my use case, which consists of a proc macro that expands Rust types from Avro schemas, and a build script that does the same thing.
This modification could break existing use cases:
If no files were found, the clients of this crate will need to treat that case like this:
This looks to me like this validation should exist in the crate, but let me know if you have any disagreements.