fix: Compare named schemas by name to avoid duplicate code generation#89
Merged
lerouxrgd merged 1 commit intolerouxrgd:masterfrom Nov 28, 2025
Merged
fix: Compare named schemas by name to avoid duplicate code generation#89lerouxrgd merged 1 commit intolerouxrgd:masterfrom
lerouxrgd merged 1 commit intolerouxrgd:masterfrom
Conversation
When apache-avro produces unequal schema objects for the same named type (e.g., when resolving references), the previous equality check would fail to detect duplicates, resulting in duplicate code generation. This fix compares Record, Enum, and Fixed schemas by their names instead.
Owner
|
Thanks for the PR ! |
Contributor
Author
|
Thank you. Would you mind doing a patch release on crates.io? |
Owner
|
Yes ! I'll release it very soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When apache-avro produces unequal schema objects for the same named type (e.g., when resolving references), the previous equality check would fail to detect duplicates, resulting in duplicate code generation. This fix compares Record, Enum, and Fixed schemas by their names instead.
Fixes #88