Refactor Bot to use TypedEventEmitter for type-safe events

[chapel]

Summary

Implemented TypedEventEmitter utility class that extends Node.js EventEmitter with compile-time type safety for event names and payloads. Refactored Bot class to use TypedEventEmitter instead of base EventEmitter.

Key changes:

• Created packages/core/src/utils/typed-event-emitter.ts with generic TypedEventEmitter class
• Added overload signatures for backward compatibility with generic EventEmitter interfaces
• Updated Bot class to extend TypedEventEmitter<BotEvents>
• Fixed BotEvents interface to match actual SessionLifecycleEvents payloads
• Exported TypedEventEmitter from @kynetic-bot/core package

Test plan

• All 1567 tests passing
• Build successful with full TypeScript type checking
• Lint checks pass
• Type safety verified - incorrect event names/payloads caught at compile time
• Backward compatibility maintained - Discord adapter works with typed Bot

Task: @01KGGX57

🤖 Generated with Claude Code

[claude]

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

[chapel]

PR Review Summary

Quality Gates

• ✅ All tests passing (1567 tests)
• ✅ CI checks passing (test, claude-review, check-unresolved-comments)
• ✅ Type safety implementation verified
• ✅ Backward compatibility maintained

Changes Overview

This PR refactors the Bot class to use a new TypedEventEmitter utility that provides compile-time type safety for event names and payloads:

1. New TypedEventEmitter utility (packages/core/src/utils/typed-event-emitter.ts)

   • Extends Node.js EventEmitter with typed emit/on/off/once methods
   • Provides compile-time type checking for event names and handler signatures
   • Includes backward compatibility overloads for generic EventEmitter interfaces

2. Bot class refactored (packages/bot/src/bot.ts)

   • Now extends TypedEventEmitter<BotEvents> instead of base EventEmitter
   • BotEvents interface updated to accurately reflect actual emitted events
   • Session lifecycle event payloads corrected to match SessionLifecycleManager

3. All existing tests pass - No behavior changes, pure refactoring for type safety

Spec Alignment

This is a technical refactoring task with no associated spec (spec_ref: null). The changes are internal improvements that don't affect observable behavior. The refactoring:

• Adds compile-time type safety without changing runtime behavior
• Maintains backward compatibility with existing event listeners
• Corrects event interface to match actual implementation

Verdict

✅ Ready to merge - All quality gates pass, implementation is sound, tests verify correctness.