Calculator Style Changes and Additional features#409
Open
vicante-web-designs wants to merge 25 commits intoleonnoel:mainfrom
Open
Calculator Style Changes and Additional features#409vicante-web-designs wants to merge 25 commits intoleonnoel:mainfrom
vicante-web-designs wants to merge 25 commits intoleonnoel:mainfrom
Conversation
Fixed the error caused by the slice function when I evaluate a calculation due to the fact that slice doesnt work on numbers, only strings. Added the toString() method to always make sure it is stringified before slicing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I completed the challenge: 3
I feel good about my code: 3
I'm haven't done it with OOP best practices, but it does what it needs to. After I created the HTML and CSS to replicate the calculator in the image, I decided to add additional features. Then I moved on to the javascript for functionality. I had a bit of trouble in using pseudocode but I'm beginning to get the hang of it. I wrote bad code, then I refactored it to make it cleaner and dryer. I'm not sure if there are any edge cases where my calculator won't work, but so far it works fine. I plan to refactor it again using OOP best practices