Fallback to hex on invalid label names #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes human readable label names are longer than allowed in kubernetes. This commit will fall back to the hex encoded vendor and device IDs. Additionally it will fall back if the device name could not be found in the `usbid.Vendor` map. Lastly some small unit test for the label key creation is added and some refactoring to make that possible.
Owner
Author
|
should solve #13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes human readable label names are longer than allowed in
kubernetes. This commit will fall back to the hex encoded vendor and
device IDs.
Additionally it will fall back if the device name could not be found in
the
usbid.Vendormap.Lastly some small unit test for the label key creation is added and some
refactoring to make that possible.