removed ack-finish-functions to be consistent with grep.el#15
Open
ssnnoo wants to merge 1 commit intoleoliu:masterfrom
Open
removed ack-finish-functions to be consistent with grep.el#15ssnnoo wants to merge 1 commit intoleoliu:masterfrom
ssnnoo wants to merge 1 commit intoleoliu:masterfrom
Conversation
Contributor
Author
|
No chance to get this in? :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ack-mode implements it own compilation-finish-functions list (ack-finish-functions), which I found confusing because running ack still triggers compilation-start-hook. Indeed, this is inconsistent with grep.el, which relies on the standard compilation-finish-functions.
So, if I want to e.g. have a spinning parrot while a compilation process is running and the spinning is triggered via compilation-start-hook, then it would be possible to stop it again in grep.el and standard compilation-mode via compilation-finish-functions, but one would need also ate dd the stop function to ack-finish-functions, otherwise the parrot will spin forever :-o. I accept that this is probably not the most important use case, but still ...