64-bit fastdiv & mod for MSVC #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added 64-bit fastdiv & mod support for MSVC via multi-word arithmetic and VS specific intrinsics. This produces almost identical asm output to GCC/Clang's __uint128_t. I also had to slightly modify the tests to make it compatible for MSVC: - Removed `#ifndef _MSC_VER` directives - `__uint128_t` => `auto` - Literals `-2147483648` & `-0x80000000` => `INT32_MIN` (to prevent overflow) - Added VS compatible `doNotOptimizeAway`
There was a bunch of superfluous indentation in the multi-word arithmetic functions.
Owner
|
Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 64-bit fastdiv & mod support for MSVC via multi-word arithmetic and VS specific intrinsics. I needed to add additional functions for that. This produces very similar asm output to GCC/Clang's __uint128_t.
I also had to slightly modify the tests to make it compatible with MSVC:
#ifndef _MSC_VERdirectives__uint128_t=>auto-2147483648&-0x80000000=>INT32_MIN(to prevent overflow)doNotOptimizeAway