Add fallback for ResolveVanity() (#14)#15
Merged
leighmacdonald merged 2 commits intoleighmacdonald:masterfrom May 25, 2025
Merged
Add fallback for ResolveVanity() (#14)#15leighmacdonald merged 2 commits intoleighmacdonald:masterfrom
leighmacdonald merged 2 commits intoleighmacdonald:masterfrom
Conversation
Owner
|
Excellent, looks good! I made a small change to the tests to ensure its tried at least once as well, but otherwise looks good. closes #14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi. I've implemented a fallback call for Vanity URL as we've discussed in #14.
I also updated documentation to mention the possibility of this call being rate-limited.
Let me know if there are any changes required.