Skip to content

Fix preview handlers failing when PowerToys installed in paths with spaces #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix preview handlers failing when PowerToys installed in paths with spaces #25

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4bb19a
Initial plan
Copilot Jun 29, 2025
d24f8fc
Fix preview handler path quoting for spaces in installation directory
Copilot Jun 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/common/utils/modulesRegistry.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ inline registry::ChangeSet getRegistryPreviewSetDefaultAppChangeSet(const std::w
std::wstring registryKeyPrefix = L"Software\\Classes\\";

std::wstring appPath = installationDir + L"\\WinUI3Apps\\PowerToys.RegistryPreview.exe";
std::wstring command = appPath + L" \"----ms-protocol:ms-encodedlaunch:App?ContractId=Windows.File&Verb=open&File=%1\"";
std::wstring command = L"\"" + appPath + L"\" \"----ms-protocol:ms-encodedlaunch:App?ContractId=Windows.File&Verb=open&File=%1\"";

changes.push_back({ scope, registryKeyPrefix + fullAppName + L"\\" + L"Application", L"ApplicationName", appName });
changes.push_back({ scope, registryKeyPrefix + fullAppName + L"\\" + L"DefaultIcon", std::nullopt, appPath });
Expand All @@ -257,8 +257,8 @@ inline registry::ChangeSet getRegistryPreviewChangeSet(const std::wstring instal
using vec_t = std::vector<registry::ValueChange>;
vec_t changes;

std::wstring command = installationDir;
command.append(L"\\WinUI3Apps\\PowerToys.RegistryPreview.exe \"%1\"");
std::wstring command = L"\"" + installationDir;
command.append(L"\\WinUI3Apps\\PowerToys.RegistryPreview.exe\" \"%1\"");
Copy link
Owner

@lei9444 lei9444 Jun 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我说的是preview pane的东西

changes.push_back({ scope, L"Software\\Classes\\regfile\\shell\\preview\\command", std::nullopt, command });

std::wstring icon_path = installationDir;
Expand Down