Fix per-user preview pane not working by detecting actual installation scope#23
Draft
Fix per-user preview pane not working by detecting actual installation scope#23
Conversation
Co-authored-by: lei9444 <39758135+lei9444@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] per user version preview pane not working
Fix per-user preview pane not working by detecting actual installation scope
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The preview pane modules were hardcoded to always register as per-user installations (
installPerUser = true), regardless of whether PowerToys was actually installed per-machine or per-user. This caused preview handlers to be registered in the wrong registry scope, making them non-functional when PowerToys was installed per-machine.Root Cause
Two key locations used hardcoded per-user values:
powerpreview.cpp:27- PowerPreviewModule constructormodulesRegistry.h:273,288-getAllOnByDefaultModulesChangeSets()andgetAllModulesChangeSets()Solution
Replaced hardcoded
truevalues with dynamic detection using the existingregistry::install_scope::get_current_install_scope()function:Changes Made
#include <common/utils/registry.h>and replaced hardcoded installation scope detectionExpected Behavior
HKEY_LOCAL_MACHINEHKEY_CURRENT_USERImpact
Fixes #22.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.