Draft
Conversation
Co-authored-by: lei9444 <39758135+lei9444@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Peek is out of order with PDF files.
Fix PDF file handling in Peek preview
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Peek was not displaying PDF files correctly. Users reported that Peek would become "out of order" when previewing PDF files, resulting in an unusable preview experience.
Root Cause
PDF files were being handled by the WebBrowserPreviewer component, which isn't optimized for displaying PDF documents. The WebBrowserPreviewer was intercepting PDF file preview requests before the more capable ShellPreviewHandlerPreviewer could handle them.
Solution
This PR makes a minimal change to fix the issue:
.pdfextension from WebBrowserPreviewer's supported file types listWith this change, when a user attempts to preview a PDF file in Peek:
This ensures that PDF files are displayed properly using the system's registered PDF preview handler rather than attempting to render them with a component not designed for this purpose.
Fixes #11.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
cdn.fwupd.org/usr/bin/fwupdmgr refresh(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.