feat!: change Sign func to work on time.Time #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
If I understand correctly, is this PR adding the ability to specify an expiry time, rather than a duration from now? |
Contributor
Author
|
@leg100 Yes. Maybe the func name could be better.. |
Owner
I think so. In hindsight, I should have defaulted to your behaviour, and let the caller calculate their own duration, should they wish to do that. (Using |
Contributor
Author
|
That would be awesome! |
Changing Sign func to work on time.Time, instead of duration.
casperrafn
force-pushed
the
add_sign_with_expiry
branch
from
bb6f545 to
50d277b
Compare
casperrafn
changed the title
leg100
changed the title
Owner
|
Looks good @casperrafn! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing Sign func to work on time.Time, instead of duration.