Add Apple code signing and notarization support #1
Open
leftouterjoins wants to merge 2 commits intomasterfrom
Open
Add Apple code signing and notarization support #1leftouterjoins wants to merge 2 commits intomasterfrom
leftouterjoins wants to merge 2 commits intomasterfrom
Conversation
Add support for signing the installer package with Apple Developer ID: build-pkg.sh: - Add --sign flag to enable code signing - Sign binary with hardened runtime (codesign) - Sign component package (pkgbuild --sign) - Sign final product archive (productsign) release.yml: - Add certificate import step (creates temporary keychain) - Conditional signing based on APPLE_CERTIFICATE_P12 secret - Notarization via xcrun notarytool - Stapling via xcrun stapler - Keychain cleanup on job completion Required GitHub Secrets (when ready): - APPLE_CERTIFICATE_P12 (base64-encoded .p12) - APPLE_CERTIFICATE_PASSWORD - APPLE_ID - APPLE_TEAM_ID - APPLE_APP_PASSWORD (app-specific password) Without secrets, releases continue to build unsigned packages. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Document the complete setup process for enabling Apple Developer ID signing and notarization for the installer package. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces automated Apple Developer ID code signing and notarization for the macOS installer package, making releases compliant with Gatekeeper and eliminating warning dialogs for users. The workflow now conditionally signs and notarizes packages when the appropriate secrets are configured, and detailed documentation is included to guide setup and troubleshooting. The installer build script (
build-pkg.sh) has been enhanced to support both unsigned and signed builds via a new--signflag.Key changes:
Apple Code Signing & Notarization Integration
.github/workflows/release.yml) now imports Apple certificates from secrets, signs the installer if configured, submits it for notarization, staples the notarization ticket, and cleans up the temporary keychain. These steps are only performed if the relevant secrets are present, otherwise an unsigned package is built as before.Installer Build Script Enhancements
Installer/build-pkg.shnow supports a--signflag to enable code signing, with logic to sign the binary, component package, and final product archive using Developer ID certificates. The script auto-detects signing identities if not provided, and prints clear status messages about signing and next steps. [1] [2] [3] [4] [5] [6]Documentation
docs/APPLE_SIGNING.md, which explains the code signing and notarization process, setup instructions for Apple certificates and GitHub secrets, and troubleshooting tips. This provides a comprehensive guide for maintainers to enable and manage signed releases.