Add Shared Layout tab with GPU memory swizzle visualization#19
Merged
Add Shared Layout tab with GPU memory swizzle visualization#19
Conversation
Implements comprehensive Shared Layout feature for visualizing GPU shared memory swizzle patterns with bank conflict analysis. Core Implementation: - SharedLayout: Swizzle math supporting standard phase-based and AMD rotating modes - SharedLayoutValidator: Comprehensive validation for swizzle parameters and tensor shapes - SharedLayoutTab: Interactive tab with real-time bank info and tooltips - 56 new tests achieving full coverage (unit, integration, bank distribution, E2E) Architecture Improvements: - Refactored ParameterForm to generic component for reusability across layout types - Added custom color provider support to CanvasRenderer for bank-based coloring - Fractional bank capacity reporting for accurate multi-bank element modeling - Single-render optimization matching other tab patterns UI Features: - AMD-focused defaults (128×64, vec=4, perPhase=2, maxPhase=4, row-major order) - Real-time bank info display (32 banks, element capacity, segments) - Interactive tooltips showing logical index, offset, segment, and bank assignment - Auto-updating form with comprehensive validation Test Coverage: - 21 unit tests for swizzle formulas and bank calculations - 11 integration tests for round-trip correctness - 5 bank distribution tests - 12 validator tests - 7 tab controller tests - 5 E2E tests for UI interactions Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements comprehensive Shared Layout feature for visualizing GPU shared memory swizzle patterns with bank conflict analysis.
Core Implementation:
Architecture Improvements:
UI Features:
Test Coverage: