Add "Show in Linear Layout" projection for WMMA and MFMA tabs#16
Merged
Add "Show in Linear Layout" projection for WMMA and MFMA tabs#16
Conversation
Extends the cross-tab layout projection system to support WMMA and MFMA tabs, with shared infrastructure to eliminate code duplication and comprehensive bug fixes. Key additions: - Shared projection helpers in CanvasTab base class (setupLinearLayoutProjection, prepareLinearLayoutSnapshot, normalizeLaneDimensionNames) - WMMA tab projection with dimension reordering (dimM/dimK/dimN) per operand type - MFMA tab projection with tensor shape clamping for small layouts (fixes 4×16 bug) - "Show in Linear Layout" buttons added to WMMA and MFMA tab UIs Bug fixes: - Fixed WMMA dimension ordering bug (dimensions now reordered to match tensor axes) - Fixed MFMA 4×16 conversion bug (layouts clamped to actual tensor size) - Fixed test organization (moved stray tests inside describe blocks) - Eliminated code duplication between Block/WMMA/MFMA tabs Test coverage: - Added CanvasTab.test.ts for shared projection helper testing - Added WMMALayoutTab.test.ts (4 tests) with dimension ordering and alert coverage - Added MFMALayoutTab.test.ts (5 tests) with 4×16 regression test - Added LinearLayoutProjection.integration.test.ts for end-to-end validation - Enhanced BlockLayoutTab.test.ts with missing edge case coverage - Total: 166 tests passing (up from 154) All three layout tabs now provide consistent projection UX with automatic dimension filtering, name normalization, and helpful error messages. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the cross-tab layout projection system to support WMMA and MFMA tabs, with shared infrastructure to eliminate code duplication and comprehensive bug fixes.
Key additions:
Bug fixes:
Test coverage:
All three layout tabs now provide consistent projection UX with automatic dimension filtering, name normalization, and helpful error messages.
🤖 Generated with Claude Code