Skip to content

Conversation

@leducp
Copy link
Owner

@leducp leducp commented Dec 12, 2025

related to #201

@github-actions
Copy link

github-actions bot commented Dec 12, 2025

File Coverage Lines Branches
All files 86% 87% 85%
lib/include/kickcat/Error.h 87% 92% 83%
lib/include/kickcat/SBufQueue.h 80% 98% 63%
lib/master/include/kickcat/Bus.h 71% 100% 42%
lib/master/src/Bus.cc 83% 85% 81%
lib/master/src/CoE.cc 85% 93% 77%
lib/master/src/Link.cc 98% 100% 97%
lib/master/src/Prints.cc 99% 99% 100%
lib/slave/src/AbstractESC.cc 90% 100% 81%
lib/slave/src/AbstractEmulatedEEPROM.cc 0% 0% 0%
lib/slave/src/ESMStates.cc 94% 99% 89%
lib/slave/src/ESM.cc 92% 93% 90%
lib/slave/src/PDO.cc 86% 92% 80%
lib/slave/src/EEPROM/EEPROM_factory.cc 0% 0% 100%
lib/slave/src/ESC/EmulatedESC.cc 53% 60% 46%
lib/slave/src/slave/Slave.cc 94% 88% 100%
lib/src/Frame.cc 87% 92% 82%
lib/src/Mailbox.cc 69% 76% 62%
lib/src/SIIParser.cc 93% 95% 91%
lib/src/protocol.cc 99% 98% 100%
lib/src/CoE/EsiParser.cc 90% 93% 87%
lib/src/CoE/OD.cc 99% 99% 100%
lib/src/CoE/mailbox/request.cc 82% 86% 77%
lib/src/CoE/mailbox/response.cc 93% 97% 88%

Minimum allowed coverage is 75%

Generated by 🐒 cobertura-action against aa30ed4

@leducp leducp requested a review from trns1997 December 14, 2025 08:39
@leducp leducp marked this pull request as ready for review December 14, 2025 08:39
ASSERT_EQ(slave_.state(), State::INIT);
}

TEST_F(SlaveTest, routine_with_mailbox)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm i do not get the tests, they work but i feel like they don't test much, maybe we should add a counter example (maybe in an other PR) where we show the slave ends up in a problem state, to cover all branches

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree
Put it in draft for the moment

@leducp leducp marked this pull request as draft December 15, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants