Fix issues on MSVC and update build instructions.

CMakeLists.txt

@@ -1,14 +1,21 @@
 cmake_minimum_required(VERSION 3.9)
 
-set(CMAKE_CXX_FLAGS -std=c++17)
+set(CMAKE_CXX_STANDARD 17)
+set(CMAKE_CXX_STANDARD_REQUIRED ON)
 
 set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${CMAKE_SOURCE_DIR}/modules)
 
-find_package(OpenMP)
-if (OPENMP_FOUND)
-  set (CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${OpenMP_C_FLAGS}")
-  set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${OpenMP_CXX_FLAGS}")
-  set (CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} ${OpenMP_EXE_LINKER_FLAGS}")
+# cmath on MSVC needs this to define M_PI etc.
+add_compile_definitions(_USE_MATH_DEFINES)
+
+# skip OpenMP on MSVC as it doesn't support OpenMP 3.0 unsigned loops
+if (!MSVC)
+  find_package(OpenMP)
+  if (OPENMP_FOUND)
+    set (CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${OpenMP_C_FLAGS}")
+    set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${OpenMP_CXX_FLAGS}")
+    set (CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} ${OpenMP_EXE_LINKER_FLAGS}")
+  endif()
 endif()
 
 add_subdirectory(src)

README.org

@@ -13,7 +13,7 @@
   #+BEGIN_SRC bash
     pushd vcpkg
     ./bootstrap-vcpkg.sh 
-    ./vcpkg install magnum-integration[imgui]
+    ./vcpkg install magnum-integration[imgui] eigen3 egl-registry
     popd
   #+END_SRC
 

src/CMakeLists.txt

@@ -1,4 +1,7 @@
+find_package(Eigen3 CONFIG REQUIRED)
+
 add_library(WaveGrid WaveGrid.cpp Enviroment.cpp Grid.cpp ProfileBuffer.cpp Spectrum.cpp ${Environment_RCS})
+target_link_libraries(WaveGrid Eigen3::Eigen)
 
 add_subdirectory(tests)
 add_subdirectory(visualization)

src/Enviroment.cpp

@@ -12,7 +12,7 @@ namespace WaterWavelets {
 
 auto &raw_data = harbor_data;
 
-const int N = sqrt(raw_data.size());
+const int N = sqrt(sizeof(raw_data) / sizeof(float));
 
 auto data_grid = [](int i, int j) -> float {
   // outside of the data grid just return some high arbitrary number

src/math/interpolation/DomainInterpolation.h

@@ -2,7 +2,7 @@
 
 #include <iostream>
 
-#include <eigen3/Eigen/Dense>
+#include <Eigen/Dense>
 
 /*
  * Domain inteprolation - Interpolates function values only for pointS in the

src/math/interpolation/ValueTraits.h

@@ -1,6 +1,6 @@
 #pragma once
 
-#include <eigen3/Eigen/Dense>
+#include <Eigen/Dense>
 
 template <class T> struct ValueTraits {
 

src/tests/CMakeLists.txt

@@ -1 +1,2 @@
 add_executable(integration_test integration_test.cpp)
+target_link_libraries(integration_test Eigen3::Eigen)

src/visualization/CMakeLists.txt

@@ -15,7 +15,6 @@ find_package(Magnum REQUIRED
   SceneGraph
   Sdl2Application)
 
-# find_package(imgui REQUIRED ImGui)
 find_package(MagnumIntegration CONFIG REQUIRED ImGui)
 
 message("ImGui Found: ${ImGUi_FOUND}")

src/visualization/base/SceneBase3D.cpp

@@ -18,6 +18,9 @@ SceneBase3D::SceneBase3D(const Arguments &arguments)
   Renderer::enable(Renderer::Feature::FaceCulling);
   Renderer::enable(Renderer::Feature::Multisampling);
 
+  Renderer::setBlendEquation(Renderer::BlendEquation::Add, Renderer::BlendEquation::Add);
+  Renderer::setBlendFunction(Renderer::BlendFunction::SourceAlpha, Renderer::BlendFunction::OneMinusSourceAlpha);
+
   /* Configure camera */
   viewportEvent(GL::defaultFramebuffer.viewport().size()); // set up camera
 
@@ -31,8 +34,18 @@ void SceneBase3D::drawEvent() {
 
   _camera.draw(_drawables);
 
+  Renderer::enable(Renderer::Feature::Blending);
+  Renderer::enable(Renderer::Feature::ScissorTest);
+  Renderer::disable(Renderer::Feature::FaceCulling);
+  Renderer::disable(Renderer::Feature::DepthTest);
+
   drawGui();
 
+  Renderer::enable(Renderer::Feature::DepthTest);
+  Renderer::enable(Renderer::Feature::FaceCulling);
+  Renderer::disable(Renderer::Feature::ScissorTest);
+  Renderer::disable(Renderer::Feature::Blending);
+
   swapBuffers();
   redraw();
 }

src/visualization/drawables/Primitives3D.cpp

@@ -145,8 +145,6 @@ Sphere::Sphere(SceneBase3D::Object3D *parent, SceneGraph::DrawableGroup3D *group
 
   auto meshData = Primitives::UVSphere::solid(rings, segments);
 
-#warning "Normals are incorrect!"
-
   _data.resize(meshData.positions(0).size());
   for (size_t i = 0; i < meshData.positions(0).size(); i++) {
     _data[i].position = Matrix4::rotationX(Rad{M_PI / 2})