Feat/#99 implement a way to listen to other actions than default ones #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #122 +/- ##
==========================================
+ Coverage 95.15% 95.40% +0.25%
==========================================
Files 69 70 +1
Lines 1093 1154 +61
Branches 126 141 +15
==========================================
+ Hits 1040 1101 +61
Misses 53 53
Continue to review full report at Codecov.
|
danielvo11
requested changes
Dec 1, 2020
| } | ||
|
|
||
| // TODO: enhance this simple check by using regex. | ||
| if (typeof actionName !== 'string' || actionName.indexOf('::') < 1) { |
Contributor
There was a problem hiding this comment.
if I input action name *, I will get error here!.
| * @param _payload The payload of the incoming Action. | ||
| */ | ||
| matchActionType(candidateType, subscribedType, _payload?): boolean { | ||
| if (subscribedType === '*') { |
Contributor
There was a problem hiding this comment.
I think it's better to allow user to subscribe to action of specific contract account. Somethings like eosio::* or governance::*
|
|
||
| protected async handleData(actionName: string, data: any, scope?: any): Promise<any> { | ||
| const handlerMap = this.#_handlersMap; | ||
| const handlerSymbols: symbol[] = handlerMap.get(actionName) || []; |
Contributor
There was a problem hiding this comment.
In case of I subscribe handler to action *, handler will never be executed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.