Remove Python 2.7 FileNotFoundError compatibility shims #13985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
DEV: backend
Since Python 2.7 is no longer supported, remove all instances of the FileNotFoundError compatibility shim that was used to map FileNotFoundError to IOError for Python 2.7 compatibility. Modified files: - kolibri/utils/file_transfer.py - kolibri/utils/filesystem.py - kolibri/utils/server.py - kolibri/core/content/utils/content_manifest.py
rtibbles
force-pushed
the
claude/remove-py27-shims-01VPXFoXyzpB4moFgnVTQXew
branch
from
9f06ed2 to
b50fa46
Compare
Contributor
Build Artifacts
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since Python 2.7 is no longer supported, remove all instances of the FileNotFoundError compatibility shim that was used to map FileNotFoundError to IOError for Python 2.7 compatibility.
Modified files:
References
Final bit of Python 2.7 compatibility code, should close #13882
Reviewer guidance
Are there any other instances of this that have been missed? Any other Python 2.7 compatibility things still extant in the codebase?
🤖 This was created by Claude Code. @rtibbles then reviewed the generated output, and did iterative rounds of updates before making it ready for review 🤖