Fixes for Slack notifications and automated replies #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisRob
force-pushed
the
fix-notification-system
branch
3 times, most recently
from
e57dbfc to
2c94197
Compare
MisRob
commented
Oct 7, 2025
scripts/constants.js
Outdated
| // for example, we receive a high priority notification about their | ||
| // comments on all issues rather than just on 'help wanted' issues | ||
| const CLOSE_CONTRIBUTORS = ['BabyElias', 'Dimi20cen', 'EshaanAgg', 'GarvitSinghal47', 'habibayman', 'iamshobhraj', 'indirectlylit', 'Jakoma02', 'KshitijThareja', 'muditchoudhary', 'nathanaelg16', 'nikkuAg', 'Sahil-Sinha-11', 'shivam-daksh', 'shruti862', 'thesujai', 'WinnyChang']; | ||
| const CLOSE_CONTRIBUTORS = ['AadarshM07', 'BabyElias', 'Dimi20cen', 'EshaanAgg', 'GarvitSinghal47', 'habibayman', 'iamshobhraj', 'indirectlylit', 'Jakoma02', 'KshitijThareja', 'muditchoudhary', 'nathanaelg16', 'nikkuAg', 'Sahil-Sinha-11', 'shivam-daksh', 'shruti862', 'thesujai', 'WinnyChang', 'yeshwanth235']; |
Member
Author
There was a problem hiding this comment.
Intended changes - I used the opportunity to update the list of close contributors.
MisRob
force-pushed
the
fix-notification-system
branch
from
42f8761 to
2dae013
Compare
MisRob
changed the title
Member
Author
|
@rtibbles before merging, I will need to revert last commit - so please just approve if all is well, and I will merge later. |
rtibbles
approved these changes
Nov 4, 2025
Member
rtibbles
left a comment
rtibbles
left a comment
There was a problem hiding this comment.
No concerns here, aside from what I've already expressed about a list of usernames committed in code - if we could encourage everyone to be 'publicly' in the org, that would be more helpful - in case it is incentive, we're already publicly naming them in this repo, so they're public either way!
Fixes learningequality#30 Fixes learningequality#31 Co-authored-by: iamshobhraj <shobhr.ug22.ec@nitp.ac.in>
MisRob
force-pushed
the
fix-notification-system
branch
from
2dae013 to
e51ced1
Compare
MisRob
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Transfers @iamshobhraj's work from my test environment to our production environment.
References
Fixes #30
Fixes #31
Reviewer guidance
This is already reviewed and tested by me. @rtibbles as usual, I'd be grateful for quick review on security or any other major issues.