-
Notifications
You must be signed in to change notification settings - Fork 6
Add default issue templates and make the header automation to run on issues from this repo #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default issue templates and make the header automation to run on issues from this repo #27
Conversation
54741e1 to
7448a3e
Compare
to work on .github repository issues as well.
7448a3e to
93323a9
Compare
| name: Manage issue header | ||
|
|
||
| on: | ||
| issues: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might it be more helpful to make a small wrapper action that does the workflow_call from within it, so that this is then an example, and a complete test of how it will be used in other repos?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, nice idea. Will do as follow-up as we chatted.
marcellamaki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my side in terms of the issue types and basic format this looks fine. I'm not sure if the comment from @rtibbles requires any follow up in terms of the action, or if we'll just do that in follow up
|
Thanks @marcellamaki. As for @rtibbles's comment, we agreed on follow-up on Slack. |
|
@marcellamaki Richard mentioned we can merge after you have a look at templates so if you feel fine about it, let's do so |
marcellamaki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed with Misha that the comment from Richard will be addressed separatedly
Summary
Adds default issue templates
Adds the default 'not open for contribution' header to all templates
Makes the issue header automation to run on issues from this repo
References
A companion of learningequality/kolibri-design-system#1037
Reviewer guidance
@marcellamaki feel free to suggest changes via review, or if your draft templates have larger amounts of changes, I welcome you to push directly here.
@rtibbles would you take a peek at the small automation tweak?