Skip to content

Dialog compound pattern#61

Merged
mwarman merged 5 commits intomainfrom
57-dialog-compound-pattern
Mar 5, 2025
Merged

Dialog compound pattern#61
mwarman merged 5 commits intomainfrom
57-dialog-compound-pattern

Conversation

@mwarman
Copy link
Member

@mwarman mwarman commented Mar 4, 2025

📢 Instructions

  • Begin with a DRAFT pull request.
  • Follow italicized instructions to add detail to assist the reviewers.
  • After completing all checklist items, change the pull request to READY.

🔧 Change Summary

Describe the changes included in this pull request. Link to the associated GitHub issue(s).

  • Dialog compound pattern #57
  • Updated the Dialog component to use the compound pattern.
  • Also using the render props pattern to make a close function available to React components which implement a dialog so that they may programmatically close a dialog.

📝 Checklist

Pull request authors must complete the following tasks before marking the PR as ready to review.

  • Complete a self-review of changes
  • Unit tests have been created or updated
  • The code is free of [new] lint errors and warnings
  • Update storybook stories as needed
  • Update project documentation as needed, README, JSDoc, etc.

🧪 Steps to Test

Describe the process to test the changes in this pull request.

The Dialog component may be viewed in Storybook. To view it in the app...

  1. Go to the task detail page for any task.
  2. Click the delete icon (trash can).
  3. A dialog to confirm task deletion is displayed.

🔗 Additional Information

Optionally, provide additional details, screenshots, or URLs that may assist the reviewer.

  • [...]

@mwarman mwarman self-assigned this Mar 4, 2025
@mwarman mwarman linked an issue Mar 4, 2025 that may be closed by this pull request
@mwarman mwarman merged commit f0c235e into main Mar 5, 2025
5 checks passed
@mwarman mwarman deleted the 57-dialog-compound-pattern branch March 5, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dialog compound pattern

1 participant