Replace the yup validation library with zod#119
Merged
Conversation
There was a problem hiding this comment.
Copilot reviewed 17 out of 18 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (1)
src/pages/Tasks/components/Form/tests/TaskForm.test.tsx:50
- The test title was updated from 'cancelled' to 'submitted', but verify that the test implementation actually simulates a submit action (and calls onSubmitSpy) rather than a cancel action.
it('should call onSubmit when submitted', async () => {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Instructions
🔧 Change Summary
Describe the changes included in this pull request. Link to the associated GitHub issue(s).
zodlibrary and removedyupyupwas used for validation such as forms and the ConfigProvider.yup.📝 Checklist
Pull request authors must complete the following tasks before marking the PR as ready to review.
🧪 Steps to Test
Describe the process to test the changes in this pull request.
View storybook and review the Form components.
Perform a full regression test of the application with specific focus on the sign in form and the task form, both edit and create tasks.
🔗 Additional Information
Optionally, provide additional details, screenshots, or URLs that may assist the reviewer.