test: LSP server verso tests #699
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGELOG.md
Outdated
| unreleased | ||
| ---------- | ||
|
|
||
| (Changes that can break existing programs are marked with a "*") |
Collaborator
There was a problem hiding this comment.
This might be confusing with Markdown already using * for bulleted lists and boldface. Maybe we should have two headers?
Author
There was a problem hiding this comment.
We agree to follow what the ref manual does and just write "breaking change" in the changes entry.
Author
|
Summary of PR review discussion with David:
|
Collaborator
I think this one isn't really necessary for a merge here. It's important, but so is avoiding bitrot and getting value from the test that's already here. One or two more should suffice to validate the approach. |
Author
Upstream is happy with this so I'll proceed with that plan. |
We add LSP tests for Verso documents; we reuse the core LSP testing infrastructure from lean4 upstream. See `doc/dev/testing.md` there for more details. This is a draft PR, some comments: - maybe we should make the effort and use the lake test runner instead of the ad-hoc test runner here - location of files / entry point to be debated - we need to ship more tests
ejgallego
force-pushed
the
test_lsp
branch
2 times, most recently
from
9e3f79d to
70158ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add LSP tests for Verso documents; we reuse the core LSP testing infrastructure from lean4 upstream. See
doc/dev/testing.mdthere for more details.This is a draft PR, some comments: