feat: elaborate block structures as concrete elements #693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| public abbrev DirectiveExpanderOf α := α → TSyntaxArray `block → DocElabM Term | ||
|
|
||
| public abbrev DirectiveElaborator := Array Arg → TSyntaxArray `block → DocElabM (Array Target.Block) |
Collaborator
There was a problem hiding this comment.
Do we want this old-school version to be public?
| let n ← mkFreshUserName <| declName ++ `directive | ||
|
|
||
| -- Find the appropriate adapter for both new (`DirectiveElabOf`) and legacy (`DirectiveExpanderOf`) declarations | ||
| let constructor ← match (← getEnv).find? declName |>.map (·.type.getAppFn) with |
Collaborator
There was a problem hiding this comment.
This is probably correct, but I figured I'd flag it up just to be sure. Right now, this will reject user-written abbrevs that expand to one of the allowed forms. The check could be done modulo defeq to allow those. I think this is correct anyway because I think the attributes reject types that don't strictly have this form, but I thought it was worth double-checking.
| let n ← mkFreshUserName <| declName ++ `directive | ||
|
|
||
| -- Find the appropriate adapter for both new (`DirectiveElabOf`) and legacy (`DirectiveExpanderOf`) declarations | ||
| let constructor ← match (← getEnv).find? declName |>.map (·.type.getAppFn) with |
Collaborator
There was a problem hiding this comment.
constructor has a specific meaning that I think we should avoid overloading. What about adapter?
| } | ||
|
|
||
| private unsafe def directiveExpandersForUnsafe' (x : Name) : DocElabM (Array (DirectiveExpander × Option String × Option SigDoc)) := do | ||
| private unsafe def directiveExpandersForUnsafe' (x : Name) : DocElabM (Array (DirectiveElaborator × Option String × Option SigDoc)) := do |
Collaborator
There was a problem hiding this comment.
Shouldn't the function be renamed too?
Suggested change
| private unsafe def directiveExpandersForUnsafe' (x : Name) : DocElabM (Array (DirectiveElaborator × Option String × Option SigDoc)) := do | |
| private unsafe def directiveElabsForUnsafe' (x : Name) : DocElabM (Array (DirectiveElaborator × Option String × Option SigDoc)) := do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.