Skip to content

fix: generate placeholder text for missing toTex implementations #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kpadmasola wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: generate placeholder text for missing toTex implementations #518

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
99d5a25
testing verso changes for inserting placeholder for missing toTex
kpadmasola Aug 25, 2025
3d9df99
suppress `No more header nesting available` error
kpadmasola Aug 25, 2025
0620a1a
remove commented code
kpadmasola Aug 26, 2025
66f790f
address review comments
kpadmasola Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/verso-manual/VersoManual/Basic.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1272,7 +1272,7 @@ instance : TeX.GenreTeX Manual (ReaderT ExtensionImpls IO) where
| panic! s!"Unknown block {b.name} while rendering.\n\nKnown blocks: {(← readThe ExtensionImpls).blockDescrs.toArray |>.map (·.fst) |>.qsort (·.toString < ·.toString)}"
let some impl := descr.toTeX
| TeX.logError s!"Block {b.name} doesn't support TeX"
return .empty
return \TeX{\textcolor{"red"}{s!"Missing toTeX for Block {b.name}"}}
impl goI goB id b.data content
inline go i content := do
let some id := i.id
Expand All @@ -1281,7 +1281,7 @@ instance : TeX.GenreTeX Manual (ReaderT ExtensionImpls IO) where
| panic! s!"Unknown inline {i.name} while rendering.\n\nKnown inlines: {(← readThe ExtensionImpls).inlineDescrs.toArray |>.map (·.fst) |>.qsort (·.toString < ·.toString)}"
let some impl := descr.toTeX
| TeX.logError s!"Inline {i.name} doesn't support TeX"
return .empty
return \TeX{\textcolor{"red"}{s!"Missing toTeX for Inline {i.name}"}}
impl go id i.data content


Expand Down
3 changes: 2 additions & 1 deletion src/verso/Verso/Doc/TeX.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ def logError [Monad m] (message : String) : TeXT g m Unit := do
def header [Monad m] (name : TeX) : TeXT g m TeX := do
let opts ← options
let some i := opts.headerLevel
| logError s!"No more header nesting available at {name.asString}"; return \TeX{\textbf{\Lean{name}}}
| logError s!"No more header nesting available at {name.asString}"
return \TeX{\textcolor{"red"}{s!"Header nesting limit reached at {name.asString}"}}
let header := opts.headerLevels[i]
pure <| .raw (s!"\\{header}" ++ "{") ++ name ++ .raw "}"

Expand Down