Skip to content

fix: add table variant for require.git field in lakefile.toml schema #11536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mhuisi merged 7 commits into from
Dec 16, 2025
Merged

fix: add table variant for require.git field in lakefile.toml schema #11536

mhuisi merged 7 commits into from
Dec 16, 2025

Conversation

@maxwell3025
Copy link
Contributor

@maxwell3025 maxwell3025 commented Dec 7, 2025 •
edited
Loading

This PR corrects the JSON Schema at src/lake/schemas/lakefile-toml-schema.json to allow the table variant of the require.git field in lakefile.toml as specified in the reference.

Closes #11535

@maxwell3025 maxwell3025 changed the title Add Table Variant for require.git Field in lakefile.toml Schema fix: add table variant for require.git field in lakefile.toml schema Dec 7, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Dec 7, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Dec 7, 2025 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 2ca3bc28590c5c33f755d3bd18252f25ea266266 --onto 455fd0b4488e2adc85f825a52e2ee7d944a5740a. You can force Mathlib CI using the force-mathlib-ci label. (2025-12-07 01:44:22)
  • ✅ Mathlib branch lean-pr-testing-11536 has successfully built against this PR. (2025-12-07 16:38:29) View Log
  • ✅ Mathlib branch lean-pr-testing-11536 has successfully built against this PR. (2025-12-07 17:39:07) View Log
  • ✅ Mathlib branch lean-pr-testing-11536 has successfully built against this PR. (2025-12-08 22:41:13) View Log

@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Dec 7, 2025 •
edited
Loading

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 2ca3bc28590c5c33f755d3bd18252f25ea266266 --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-12-07 01:44:23)
  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-12-07 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-12-07 15:34:31)

@maxwell3025 maxwell3025 marked this pull request as ready for review December 7, 2025 03:50
@maxwell3025 maxwell3025 requested a review from tydeu as a code owner December 7, 2025 03:50
@maxwell3025
Copy link
Contributor Author

maxwell3025 commented Dec 7, 2025 •
edited
Loading

I don't have the permissions necessary to add labels, but this should have the label changelog-server

@maxwell3025 maxwell3025 marked this pull request as draft December 7, 2025 03:58
@maxwell3025 maxwell3025 marked this pull request as ready for review December 7, 2025 03:58
mhuisi
mhuisi requested changes Dec 7, 2025
View reviewed changes
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Dec 7, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#11536
1a91ac1
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Dec 7, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#11536
77d46a3
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Dec 7, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Dec 7, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for leanprover/lean4#11536
509ab76
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Dec 7, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for leanprover/lean4#11536
156a05d
@mhuisi mhuisi added the changelog-server Language server, widgets, and IDE extensions label Dec 8, 2025
@maxwell3025 maxwell3025 mentioned this pull request Dec 8, 2025
Merged
@maxwell3025 maxwell3025 requested a review from mhuisi December 8, 2025 20:39
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Dec 8, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for leanprover/lean4#11536
4216f1f
@github-actions github-actions bot added the mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN label Dec 8, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Dec 8, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for leanprover/lean4#11536
b2dcbf3
@mhuisi mhuisi added this pull request to the merge queue Dec 16, 2025
Merged via the queue into leanprover:master with commit 8f80d2c Dec 16, 2025
17 checks passed
mhuisi pushed a commit to leanprover/vscode-lean4 that referenced this pull request Dec 20, 2025
@maxwell3025
test: add tests for lakefile-toml-schema.json (#694)
a453185 
This pull request adds tests to make sure that
[lakefile-toml-schema](https://raw.githubusercontent.com/leanprover/lean4/refs/heads/master/src/lake/schemas/lakefile-toml-schema.json)
has no false positives and minimal false negatives *(or the other way
around? Maintainer please confirm/deny)*.

As discussed in [this pull
request](leanprover/lean4#11536), tests for the
`lakefile.toml` schema are placed here since the tests in this repo are
better maintained and this location avoids adding another dependency to
the test suite for the main project.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tydeu tydeu Awaiting requested review from tydeu tydeu is a code owner

@mhuisi mhuisi Awaiting requested review from mhuisi

Assignees

No one assigned

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-server Language server, widgets, and IDE extensions mathlib4-nightly-available A branch for this PR exists at leanprover-community/mathlib4-nightly-testing:lean-pr-testing-NNNN toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect Types in TOML Schema for lakefile.toml

4 participants

@maxwell3025 @leanprover-community-bot @leanprover-bot @mhuisi