fix: Resolving name clashing issue with size_push theorem and syntax error#91
Merged
seanmcl merged 1 commit intoleanprover:mainfrom Oct 9, 2025
Merged
Conversation
segevem
requested review from
govereau,
joonwonc,
jtristan and
seanmcl
as code owners
seanmcl
reviewed
Oct 8, 2025
seanmcl
reviewed
Oct 8, 2025
seanmcl
approved these changes
Oct 8, 2025
Collaborator
|
Thanks again. Please squash your commits and we can merge. |
Resolving name clashing issue with size_push theorem in ByteArray.lean when Batteries is imported and syntax error in Iterator.lean
segevem
force-pushed
the
fix-name-clash
branch
from
033f918 to
7161c8e
Compare
Author
|
Thank you! Squashed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using TensorLib and a dependency which depends on Batteries, the
size_pushtheorem in Batteries clashes with the one defined in TensorLib. Fixed by removing the one in TensorLib and importing Batteries' version ofByteArrayto supply thesize_pushtheorem.Removed a space behind a match expression in Iterator.lean which caused a syntax error.