Change the replacement style used for mathlib3port to keep#251
Open
eric-wieser wants to merge 1 commit intomasterfrom
Open
Change the replacement style used for mathlib3port to keep#251eric-wieser wants to merge 1 commit intomasterfrom
keep#251eric-wieser wants to merge 1 commit intomasterfrom
Conversation
These `#print`s and surrounding comments are annoying to remove when re-porting files, and having the declarations commented out isn't particularly useful anyway. The real motivation here is to make mathport produce a tree that is suitable for inserting between the mathlib3 and mathlib4 history, with ideally-minimal diffs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These
#prints and surrounding comments are annoying to remove when re-porting files, and having the declarations commented out isn't particularly useful anyway.The real motivation here is to make mathport produce a tree that is suitable for inserting between the mathlib3 and mathlib4 history, with ideally-minimal diffs