-
Notifications
You must be signed in to change notification settings - Fork 990
feat(scripts): add find-ci-errors.sh to diagnose widespread CI failures #33691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Adds a script that searches through recent failed CI workflow runs to find open PRs whose current CI contains a specific error string. Useful for diagnosing widespread CI issues affecting multiple PRs. Supports `--please-merge-master` flag to automatically add the label to affected PRs (triggering a rebuild), except those with merge conflicts. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
PR summary 402b97b2caImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
bryangingechen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not opposed to this PR, but I also don't see myself using this script.
I think what I had in mind for the please-merge-master label was just that we'd have a policy of applying it to all open PRs whenever we made a change that would break CI globally.
By the way, I don't think it's a good idea to remove such a please-merge-master label when a build completes either: there could be situations where a build succeeds but still needs a merge of master (if it's in progress when the breaking change hits master for example) and builds can also fail to complete even after they've merged master. It might be better to store the first good commit after a breaking change somewhere and then have CI remove the label if the branch contains that commit.
If you think this will be useful, feel free to merge though!
bors d+
| # Options: | ||
| # --please-merge-master Add the 'please-merge-master' label to all matching PRs | ||
| # (except those with the 'merge-conflict' label). | ||
| # The label is automatically removed by CI once the build completes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # The label is automatically removed by CI once the build completes. |
This isn't actually true (yet?) right?
| except those with the `merge-conflict` label. The label is automatically removed | ||
| by CI once the build completes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| except those with the `merge-conflict` label. The label is automatically removed | |
| by CI once the build completes. | |
| except those with the `merge-conflict` label. |
|
✌️ kim-em can now approve this pull request. To approve and merge a pull request, simply reply with |
This PR adds a script that searches through recent failed CI workflow runs to find open PRs whose current CI contains a specific error string. Useful for diagnosing widespread CI issues affecting multiple PRs (e.g., infrastructure problems, toolchain bugs).
Usage:
The
--please-merge-masterflag skips PRs with merge conflicts, and the label is automatically removed by CI once the build completes.🤖 Prepared with Claude Code