-
Notifications
You must be signed in to change notification settings - Fork 987
chore: tidy various files #33687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
chore: tidy various files #33687
Conversation
Ruben-VandeVelde
commented
Jan 6, 2026
PR summary d23aee9c01Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for Decrease in tech debt: (relative, absolute) = (1.00, 0.00)
Current commit 1e5996c79c You can run this locally as
|
grunweg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this clean-up. Looks nice, as usual - just minor comments.
bors d+
| We also define a predicate `MeasureTheory.OuterMeasure.IsMetric` which says that an outer measure | ||
| is additive on metric separated pairs of sets: `μ (s ∪ t) = μ s + μ t` provided that | ||
| `⨅ (x ∈ s) (y ∈ t), edist x y ≠ 0`. This is the property required for the Carathéodory theorem | ||
| `⨅ (x ∈ s) (y ∈ t), edist x y ≠ 0`. This is the property required for the Carathéodory's theorem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| `⨅ (x ∈ s) (y ∈ t), edist x y ≠ 0`. This is the property required for the Carathéodory's theorem | |
| `⨅ (x ∈ s) (y ∈ t), edist x y ≠ 0`. This is the property required for Carathéodory's theorem |
| hI i (Or.inl rfl) j (Or.inr hj) (ne_of_mem_of_not_mem hj hiI).symm] | ||
|
|
||
| /-- Carathéodory theorem. If `m` is a metric outer measure, then every Borel measurable set `t` is | ||
| /-- Carathéodory's theorem. If `m` is a metric outer measure, then every Borel measurable set `t` is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| /-- Carathéodory's theorem. If `m` is a metric outer measure, then every Borel measurable set `t` is | |
| /-- **Carathéodory's theorem**: If `m` is a metric outer measure, then every Borel measurable set `t` is |
| (fun a _ => mem_setOf.mpr <| | ||
| ⟨hxi.pow a, fun φ => by simp [pow_le_one₀ (norm_nonneg (φ x)) <| hx φ]⟩) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optional
| (fun a _ => mem_setOf.mpr <| | |
| ⟨hxi.pow a, fun φ => by simp [pow_le_one₀ (norm_nonneg (φ x)) <| hx φ]⟩) | |
| (fun a _ ↦ mem_setOf.mpr <| | |
| ⟨hxi.pow a, fun φ ↦ by simp [pow_le_one₀ (norm_nonneg (φ x)) <| hx φ]⟩) |
| use r_nn | ||
| grind | ||
| simp_rw [← pos_iff_ne_zero, NNReal.exists, ← NNReal.coe_pos, NNReal.coe_mk] | ||
| grind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll presume these proofs are not eyeball-slower?
| rw [h hi, Real.coe_toNNReal] | ||
| positivity | ||
| simp_rw [← pos_iff_ne_zero, NNReal.exists, ← NNReal.coe_pos, NNReal.coe_mk] | ||
| grind |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
|
✌️ Ruben-VandeVelde can now approve this pull request. To approve and merge a pull request, simply reply with |